Coda File System

[PATCH] allow backup utility to mark volumes as ancient

From: Neil Horman <>
Date: Tue, 28 Oct 2008 15:35:30 -0400
Hey all-
	I had recently set up a backup server using the latest git tree and
discovered that while backups could be taken the backup utility wasn't properly
marking the backed up volumes as ancient.  I found I was able to do so manually,
but needed to specify the backup volume id to volutil, rather than the primary
volume id.  The backup utility was having the same issue, and I wrote this patch
to fix it.  With it, I'm able to take backups and mark the corresponding volumes
as ancient properly.  I also converted the call to use NewVolMarkAsAncient,
which is in line with what volutil uses.


Signed-off-by: Neil Horman <> |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/coda-src/volutil/ b/coda-src/volutil/
index ddab9c2..2127f9e 100644
--- a/coda-src/volutil/
+++ b/coda-src/volutil/
@@ -708,7 +708,7 @@ int MarkAsAncient(volinfo_t *vol) {
 	    if (Hosts[reps[i].serverNum].rpcid == BADCONNECTION)
-	    rc= VolMarkAsAncient(Hosts[reps[i].serverNum].rpcid, volId, reps[i].repvolId);
+	    rc= NewVolMarkAsAncient(Hosts[reps[i].serverNum].rpcid, reps[i].backupId);
 	    if (rc != RPC2_SUCCESS) {
 		LogMsg(0,0,stdout, "VolMarkAsAncient (%x) failed on %x with %s\n", 
 		       Hosts[reps[i].serverNum].rpcid, /* For debugging. */
 * Neil Horman <>
 * Software Engineer, Red Hat
Received on 2008-10-28 16:41:29