Coda File System

Re: Coda Kernel Module v6.2 [resend with attachments]

From: Jan Harkes <>
Date: Fri, 30 Sep 2005 13:48:56 -0400
On Fri, Sep 30, 2005 at 11:20:42AM -0600, Patrick Walsh wrote:
> > I have tried a build and got a lot of gcc4 errors/warnings. A pretty big
> > one is in linux2.4/psdev.c, attached the patch. If I can find the
> 	OK.
> > code. Now I'm getting a bit suspicious of that fput(host_file) change
> > that was added to file.c. If there was an error, it should be a NULL. I
> > think this fix really needs to move to another place.
> 	Shall I hold off then on a new build until you've investigated and
> patched file.c?  Or do you think I'll be okay with my patch plus your
> patch to psdev.c?

Just use linux-coda-6.1.tgz for now.

I already have some things fixed, but with the fput, i'm not sure if it
might result in a kernel oops when a non-existing file is opened, or
whether the fix introduces a memory leak, when an open fails. So I
really have to test these changes.

Received on 2005-09-30 13:50:22