Coda File System

Re: CVS updates take down the client

From: Stephen J. Turnbull <>
Date: Wed, 17 Sep 2003 09:25:59 +0900
FYI, status update: all green.

>>>>> "sjt" == Stephen J Turnbull <> writes:

    sjt> Just FYI, I've finally gotten around to applying this patch.
    sjt> The workspace is otherwise straight CVS HEAD, up-to-date as
    sjt> of Sep 2 11:00 UTC or so, except for a couple of ancient
    sjt> tweaks to stuff in debian/.

After two more weeks experience with the patch (included for ease of
reference, slightly different from the one applied to CVS), I have had
no disconnects, no dangling CMLs, no client crashes, in short, no
problems in the area of connected operation.  Daily CVS updates to the
relevant volumes (containing XEmacs sources), except for two or three
days where the Coda token had expired, so the problematic operation
has been repeated at least 10 times.

Of course I don't know if this could have bad effects on somebody
else's corner case, but mine has been fully addressed.  Thanks!

>>>>> "Jan" == Jan Harkes <> writes:

    Jan> On Thu, Aug 14, 2003 at 02:23:01PM +0900, Stephen J. Turnbull
    Jan> wrote:

    >> Assertion failed: f, file "", line 2256

    Jan> So instead of asserting because we can't find it, we should
    Jan> probably just 'skip' the (already removed?) object.

    Jan> Jan

---	2003-06-01 19:03:52.000000000 -0400
+++	2003-08-21 21:55:25.000000000 -0400
@@ -2253,10 +2253,11 @@
 		    LOG(0, ("ClientModifyLog::COP1: stale dir %s\n", 
 		    fsobj *f = FSDB->Find(&StaleDir);
-		    CODA_ASSERT(f);
-		    Recov_BeginTrans();
+		    if (f) {
+			Recov_BeginTrans();
-		    Recov_EndTrans(DMFP);
+			Recov_EndTrans(DMFP);
+		    }

Institute of Policy and Planning Sciences
University of Tsukuba                    Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
               Ask not how you can "do" free software business;
              ask what your business can "do for" free software.
Received on 2003-09-16 20:30:46